lld: build with 2M stack size on musl#218657
Conversation
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
Commit message should read lld though, maybe indicate somehow that it is about all available versions.
Port of 6485a02 ("llvm 14 lld: build with 2M stack size to fix firefox lto").
alyssais
force-pushed
the
lld-stack-size
branch
from
9cb2509 to
be9bdda
Compare
I think we should get into the habit of being surprised when an LLVM change is not applied to all versions, not when it is. |
ofborg
bot
requested review from
Ericson2314,
dtzWill,
lovek323,
primeos and
sternenseemann
ofborg
bot
added
10.rebuild-darwin: 11-100
There was a problem hiding this comment.
Subjective (and something I should have raised on the original PR or in the LLVM 15 PR) so feel free to ignore:
I'd really appreciate a comment here explaining why this is necessary (perhaps with a link to this (and maybe this/this) and a short snippet saying that the pkgsMusl.firefox needs this -- or even just a link to #191372).
IMO it's a little hard to infer why this is needed from the surrounding context and while all the details are definitely still available in PR comments/commit messages, with our "copy the previous llvmPackages's files" flow it takes a bit of effort to map back to the original commit (though I guess having llvmPackages_git and keeping it up to date remedies this, somewhat).
Suggested-by: Rahul Butani <rrbutani@users.noreply.github.com>
alyssais
changed the title
rrbutani
added
the
6.topic: llvm/clang
4 participants
Description of changes
Port of 6485a02 ("llvm 14 lld: build with 2M stack size to fix firefox lto").
LLVM 7 doesn't build for Musl for unrelated reasons, as it segfaults during a test. I gave up trying to fix it when I realised it doesn't do that if I
enableDebugging.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)